Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix weird lambda strings in Prometheus output. #931

Closed
wants to merge 1 commit into from
Closed

Attempt to fix weird lambda strings in Prometheus output. #931

wants to merge 1 commit into from

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Mar 6, 2023 •
edited by github-actions bot
Loading

Hopefully fixes #924

📚 Documentation preview 📚: https://datacube-ows--931.org.readthedocs.build/en/931/

@SpacemanPaul SpacemanPaul requested a review from omad March 6, 2023 03:35
omad
omad approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

This feels like it'll solve the immediately problem, and is a safe thing to do.

I think there's plenty of scope for either refining or making more configurable the reported metrics, but haven't worked out exactly how yet.

Thanks!

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #931 (af4f7e5) into master (029d017) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #931   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          43       43           
  Lines        6385     6385           
=======================================
  Hits         6002     6002           
  Misses        383      383
Impacted Files Coverage Δ
datacube_ows/ogc.py 85.61% <ø> (ø)

@Ariana-B
Copy link

Ariana-B commented Mar 6, 2023

I'm not convinced this will be sufficient, given that query_request, query_service, and status all also show up as <function <lambda> at ...>.

@omad omad self-requested a review March 6, 2023 03:54
@omad
Copy link
Member

omad commented Mar 6, 2023

Good catch Ariana!

eg.

ows_ogc_bucket{le="0.005",query_layer="<function <lambda> at 0x7fac684ba950>",query_request="<function <lambda> at 0x7fac684b81f0>",query_service="<function <lambda> at 0x7fac684ba710>",query_version="<function <lambda> at 0x7fac684ba8c0>",status="<function <lambda> at 0x7fac684ba9e0>"} 0.0

@SpacemanPaul
Copy link
Contributor Author

Oh I see, it's the histogram aggregations that are broken. Hmmmm....

@SpacemanPaul SpacemanPaul marked this pull request as draft March 17, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omad omad Awaiting requested review from omad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhelpful metric labels for lambda layers
3 participants
@SpacemanPaul @Ariana-B @omad